Move ICodeFixService back to Features layer#78132
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom Apr 13, 2025
Merged
Move ICodeFixService back to Features layer#78132CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 12, 2025
src/LanguageServer/Protocol/Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj
Outdated
Show resolved
Hide resolved
…ver.Protocol.csproj
Contributor
Author
|
@JoeRobich @dibarbet @ToddGrun @tmat ptal. |
This was referenced Apr 19, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This oddly got moved up to the LSP layer. There was only one line in it that seems to be causing this, and it was trivial to address. So i moved it back, as this is the more appropriate layer (it is feature-level, without any LSP dependencies).